This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
refactor: Drop legacy interfaces that are no longer in use #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the following legacy interfaces: - interface_grafana_support - interface_influxdb - interface_elasticsearch These interfaces are no longer in use and will be replaced by COS. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
|
This pull request is superseded by #26 We're going to keep Fluentbit and NHC until COS has reached full feature compatibility. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 👋
Revisiting some work that we had discussed doing a few months ago! Finally getting around to it as @jedel1043 are getting ready to begin working on the COS integration for Charmed HPC. Let me know if you have any questions 🚀
Description
Drop the following legacy interfaces:
These interfaces are no longer in use and will be replaced by COS-related interfaces.
How was the code tested?
I ran the tests locally on my Ubuntu 23.10 Mantic Minotaur workstation.
Related issues and/or tasks
We decided to remove these interfaces as they are no longer in use and will be replaced by COS. We had this discussion during the Ubuntu HPC community call a few months ago. See the relevant meeting notes below:
https://discourse.ubuntu.com/t/ubuntu-hpc-meeting-notes-2024-3-27/43690#deprecating-legacy-interfaces-in-slurmctld-operator-4
Checklist